Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support draft URLs with www. prefix and query parameters #18

Merged
merged 3 commits into from
Nov 9, 2024
Merged

Support draft URLs with www. prefix and query parameters #18

merged 3 commits into from
Nov 9, 2024

Conversation

Kjir
Copy link
Contributor

@Kjir Kjir commented Nov 9, 2024

No description provided.

@ZetaTwo
Copy link
Owner

ZetaTwo commented Nov 9, 2024

Thanks! At this point, I think we should replace the whole thing with new URL(...).foo instead to do proper URL parsing instead of regex.

@Kjir
Copy link
Contributor Author

Kjir commented Nov 9, 2024

Done!

@ZetaTwo ZetaTwo merged commit 75d723c into ZetaTwo:main Nov 9, 2024
1 check passed
@ZetaTwo
Copy link
Owner

ZetaTwo commented Nov 9, 2024

Looks great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kjir @ZetaTwo