Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support React 19 #114

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: Support React 19 #114

wants to merge 2 commits into from

Conversation

amannn
Copy link

@amannn amannn commented Dec 6, 2024

No description provided.

@amannn
Copy link
Author

amannn commented Jan 27, 2025

@ZeeCoder Any chance this could be merged and released?

@ZeeCoder
Copy link
Owner

Not without having dedicated tests for React 19 alongside React 18, I'm sorry

@amannn
Copy link
Author

amannn commented Jan 28, 2025

@ZeeCoder I've updated the dev dependency of React to 19 and tests seem to run.

The only thing I had to change was a usage of useRef within the library, to match the updated types of React (which require an argument to useRef), but for consumers it shouldn't make a difference.

Does that look good to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants