fix(test): Fixes a bug in the sending_transactions_using_lightwalletd test
#9052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C-bug
arya2
force-pushed
the
fix-send-tx-test
branch
from
4234291
to
0ecf779
Compare
… code for sending transactions to its own fn
arya2
commented
Nov 23, 2024
There was a problem hiding this comment.
This test could also fail due to transactions having unpaid actions (which are allowed by default in blocks but rejected by default in the mempool).
I'm looking into why it failed here: https://github.com/ZcashFoundation/zebra/actions/runs/11979091682/job/33400891720?pr=9052#step:15:844 where that transaction did pay the conventional fee.
The log also indicates that lightwalletd can't parse errors returned from Zebra's sendrawtransaction method, seemingly because it's expecting a colon-separated string but is receiving JSON.
…eturn an error for more detailed error info
arya2
force-pushed
the
fix-send-tx-test
branch
from
98bb7a4
to
07fa64e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes a bug in the
sending_transactions_using_lightwalletdtest where transactions from multiple future blocks are being sent to the mempool without committing prior blocks to the chain.Solution
Submits blocks to the state after sending their transactions to the mempool.
Tests
The test should pass in CI.
PR Author's Checklist
PR Reviewer's Checklist