fix(rpc): Refactor getrawtransaction & RPC error handling

[upbqdn]

Motivation

Close #8945.

Specifications & References

• https://zcash.github.io/rpc/getrawtransaction.html
• https://github.com/zcash/zcash/blob/99ad6fdc3a549ab510422820eea5e5ce9f60a5fd/src/rpc/rawtransaction.cpp#L340

Solution

• Fix the bugs described in bug: getrawtransaction output conflicts with zcashd output #8744. Note that zcashd stores transactions in orphaned blocks and responds to queries requesting such transactions with height to -1. Since Zebra doesn't keep orphaned blocks below the rollback limit, it now returns the error "No such mempool or blockchain transaction". If we wanted to match zcashd, we'd need to start storing orphaned blocks.
• Fix the error codes for getrawtransaction and some other RPCs.
• Related cleanups:
  • Refactor the error handling for RPCs.
  • Add references to the original error codes.
  • Use HexData instead of Strings in getrawtransaction.
  • Simplify prop tests and run them with arbitrary Networks.

Tests

Update and add

• snapshot tests,
• unit tests, and
• prop tests

to check the new error codes.

Follow-up Work

• None

PR Author's Checklist

• The PR name will make sense to users.
• The PR provides a CHANGELOG summary.
• The solution is tested.
• The documentation is up to date.
• The PR has a priority label.

PR Reviewer's Checklist

• The PR Author's checklist is complete.
• The PR resolves the issue.

[arya2]

This is looking good so far, I left an optional suggestion about matching zcashd's output when a transaction is found in a side chain.

I'd like to review the changes to the get_block() method against #9006 if we can target this PR against the get-block branch (or wait for #9006 to merge and rebase off of main).

[arya2]

Error constructor methods for commonly-used error codes (or just Misc) could be nice here.

Suggested change

	/// A trait for mapping errors to [`jsonrpc_core::Error`].
	pub(crate) trait MapError<T> {
	/// Maps errors to [`jsonrpc_core::Error`] with a specific error code.
	fn map_error(
	self,
	code: impl Into<jsonrpc_core::ErrorCode>,
	) -> std::result::Result<T, jsonrpc_core::Error>;
	}
	/// A trait for conditionally converting a value into a `Result<T, jsonrpc_core::Error>`.
	pub(crate) trait OkOrError<T> {
	/// Converts the implementing type to `Result<T, jsonrpc_core::Error>`, using an error code and
	/// message if conversion is to `Err`.
	fn ok_or_error(
	self,
	code: impl Into<jsonrpc_core::ErrorCode>,
	message: impl ToString,
	) -> std::result::Result<T, jsonrpc_core::Error>;
	}
	/// A trait for mapping errors to [`jsonrpc_core::Error`].
	pub(crate) trait MapError<T>: Sized {
	/// Maps errors to [`jsonrpc_core::Error`] with a specific error code.
	fn map_error(
	self,
	code: impl Into<jsonrpc_core::ErrorCode>,
	) -> std::result::Result<T, jsonrpc_core::Error>;
	/// Maps errors to [`jsonrpc_core::Error`] with a [`LegacyCode::Misc`] error code.
	fn map_misc_error(self) -> std::result::Result<T, jsonrpc_core::Error> {
	self.map_error(LegacyCode::Misc)
	}
	}
	/// A trait for conditionally converting a value into a `Result<T, jsonrpc_core::Error>`.
	pub(crate) trait OkOrError<T>: Sized {
	/// Converts the implementing type to `Result<T, jsonrpc_core::Error>`, using an error code and
	/// message if conversion is to `Err`.
	fn ok_or_error(
	self,
	code: impl Into<jsonrpc_core::ErrorCode>,
	message: impl ToString,
	) -> std::result::Result<T, jsonrpc_core::Error>;
	/// Converts the implementing type to `Result<T, jsonrpc_core::Error>`, using a [`LegacyCode::Misc`] error code.
	fn ok_or_misc_error(
	self,
	message: impl ToString,
	) -> std::result::Result<T, jsonrpc_core::Error> {
	self.ok_or_error(LegacyCode::Misc, message)
	}
	}

[arya2]

This could be typed as a transaction::Hash (which implements ToHex & FromHex), though it may return the wrong error code that way.

[arya2]

Optional: To match zcashd's output when a transaction is on a side chain, we either need a new request to check for transactions on side chains, or to update this request so that it checks side chains for the transaction id too and returns an enum variant indicating whether the transaction was found on the best chain or a side chain.