fix changing albums crash #747
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikKovIos
reviewed
Jun 10, 2022
| @@ -53,6 +53,16 @@ extension YPLibraryVC { | |||
| } | |||
|
|
|||
| // MARK: - Library collection view cell managing | |||
| private func getSelectedIndexPaths(selectedItems: [YPLibrarySelection]) -> [IndexPath] { | |||
| let collectionViewItemsCount = v.collectionView.numberOfItems(inSection: 0) | |||
| var SelectedIndexPaths = [IndexPath]() | |||
There was a problem hiding this comment.
vars don't called uppercased in swift
There was a problem hiding this comment.
sorry for the typo. it is updated it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
steps to reproduce:
you have 2 albums in you gallery (recents album (has 30 media items), screenshots album (has 9 media items))
note that (screenshots album) has the screenshots images in (recents album)
app will crash because reload items for selectedIndexPaths will reload 15 indexpath while screenshots albums collection view has only 9 indexpaths.
what i do:
change selectedIndexPaths variable to be have only 9 cells.