[FIDO] Support extensions #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
SpotBugs found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
dainnilsson
reviewed
Nov 22, 2024
| @@ -364,6 +418,24 @@ public CredentialManager getCredentialManager(char[] pin) | |||
| } | |||
| } | |||
|
|
|||
| protected static class WithExtensionResults<T> { | |||
There was a problem hiding this comment.
Could we just re-use Pair for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for defined FIDO extensions (see CTAP2.1 and Webauthn specifications). This PR also adds simple framework for adding new extensions, by extending the
Extensionclass and implementing relevant methods.Extension processing happens during
BasicWebauthnClient.makeCredentialandBasicWebauthnClient.getAssertioncalls, based on the creation and request options.Results are exposed through
PublicKeyCredential.getClientExtensionResults().The following extensions are implemented:
A new BasicWebauthnClient constructor takes a list of Extension objects which it will process, by default the list contains defined extensions.
There are instrumented tests for each of the extensions (note that a supporting HW is needed for running the tests).