Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests #135

Merged
merged 9 commits into from
Aug 7, 2024
Merged

Refactor tests #135

merged 9 commits into from
Aug 7, 2024

Conversation

DennisDyallo
Copy link
Collaborator

Description

  • Added constants for test categories
  • Consolidated device selection logic
  • Added GetBySerial()
  • Minor refactors around integration testing
  • Removed unused test

@DennisDyallo DennisDyallo merged commit ffcd85b into develop Aug 7, 2024
4 checks passed
@DennisDyallo DennisDyallo deleted the dennisdyallo/improved-testing branch August 7, 2024 21:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

Code Coverage

Package Line Rate Branch Rate Complexity Health
Yubico.Core 42% 31% 4257 ➖
Yubico.YubiKey 50% 47% 19089 ➖
Summary 49% (31993 / 65943) 44% (8185 / 18519) 23346 ➖

Minimum allowed line rate is 40%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DennisDyallo