Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Config.php and use isSetFlag method for boolean functions #214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clean up Config.php and use isSetFlag method for boolean functions #214

wants to merge 1 commit into from

Conversation

vmalyk
Copy link
Contributor

@vmalyk vmalyk commented Nov 15, 2019

  1. Fixed getters for boolean params and used isSetFlag
  2. Fixed Default value to as more changes scope to ScopeInterface::SCOPE_STORE instead null
  3. Removed checking $this->isSingleStoreMode() - it`s handled by Magento framework

@lgreenboim lgreenboim mentioned this pull request Apr 1, 2020
Merged
lgreenboim
lgreenboim reviewed Apr 1, 2020
View reviewed changes
Copy link
Contributor

@lgreenboim lgreenboim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vmalyk Thank you for the pull-request, but the commit is rejected as it might cause issues in single store mode.

@vmalyk
Copy link
Contributor Author

vmalyk commented Apr 1, 2020

@lgreenboim, thank you for checking. Can you provide details about issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgreenboim lgreenboim lgreenboim left review comments

@pniel-cohen pniel-cohen Awaiting requested review from pniel-cohen

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmalyk @lgreenboim