Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify devloops that include a runtime build #39

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Simplify devloops that include a runtime build #39

wants to merge 2 commits into from

Conversation

solsson
Copy link
Collaborator

@solsson solsson commented May 11, 2021

Adds support for y-build-like-sync with an arg like:

  • builds-registry.ystack.svc.cluster.local/yolean/assert-runtime-nodejs:1234567-dirty
    • When building the runtime locally with for example Docker, or kubernetes-assert's ./hooks/build
  • builds-registry.ystack.svc.cluster.local/yolean/assert-runtime-nodejs:../../kubernetes-assert/runtime-nodejs
    • When building locally with Docker and the build is a plain context dir with ./Dockerfile

solsson added a commit to Yolean/kubernetes-assert that referenced this pull request May 11, 2021
@solsson
Makes use of Yolean/ystack#39 so we can iterate on runtime+specs
abc1f63
@solsson solsson mentioned this pull request May 11, 2021
Merged
solsson added a commit that referenced this pull request May 11, 2021
@solsson
Make use of #39 to review Yolean/kubernetes-assert#26
505a4ba
solsson added a commit that referenced this pull request May 11, 2021
@solsson
Revert "Do we still have this issue?" -- Yes we do, or don't we?
cc70ec7 
Current issue was that `crane verify` was very slow. Is it always?
Anyhow this change wasn't necessary for #39

This reverts commit 5179727.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@solsson