Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force alignment of allocated memory to prevent segmentation faults on ARM systems #224

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Jan 21, 2024

  1. Force alignment of allocated memory. Without this change, I have noti…

    …ced crashes on ARM based devices which have stricter alignment requirements than x86. Ideally, this code should be rewritten to pad the sizes of all "structs" and to consider all of the different architecture-specific alignment requirements. But in practice, I suspect that rounding up allocation sizes to a multiple of pointer sizes is likely good enough. This is a pragmatic one-line change that shouldn't break existing code and should prevent any of the crashes that I have observed.
    gutschke committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    f72893f View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Added a few more memory alignments when using both primary and extra …

    …memory in a back-to-back memory allocation.
    gutschke committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    8e7fb7b View commit details
    Browse the repository at this point in the history