Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add rules for nullable cases #28

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

macisamuele
Copy link
Collaborator

This PR fixes #22 by adding two new rules: RES-E004 and REQ-E004.

Currently the rules are fully implemented and tested.

The PR is labeled as WIP as documentation is still missing.

Side note: The skeletons (first two commits of this PR) were created with #26 🎉

@macisamuele macisamuele requested a review from sjaensch February 17, 2020 09:05
@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #28    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files          60     68     +8     
  Lines        1898   2102   +204     
  Branches      121    133    +12     
======================================
+ Hits         1898   2102   +204
Impacted Files Coverage Δ
docs/source/rules/examples/REQ-E004/tester.py 100% <100%> (ø)
docs/source/rules/examples/RES-E004/tester.py 100% <100%> (ø)
...er_spec_compatibility/walkers/changed_xnullable.py 100% <100%> (ø)
...les/removed_nullable_property_from_request_test.py 100% <100%> (ø)
...ility/rules/added_nullable_property_in_response.py 100% <100%> (ø)
.../rules/added_nullable_property_in_response_test.py 100% <100%> (ø)
tests/walkers/changed_xnullable_test.py 100% <100%> (ø)
...ty/rules/removed_nullable_property_from_request.py 100% <100%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbe71f1...2d91634. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement detection rules for adding / removing x-nullable attribute
1 participant