Backward compatibility of #794 #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprudhomme
reviewed
Dec 6, 2024
| @@ -766,6 +766,7 @@ message SearchResponse { | |||
| double rescoreTimeMs = 10; | |||
| map<string, double> rescorersTimeMs = 11; | |||
| map<string, Diagnostics> innerHitsDiagnostics = 12; | |||
| double loggingHitsTimeMs = 13; | |||
There was a problem hiding this comment.
This needs to use the same field number as the main branch, to keep the clientlib compatible
There was a problem hiding this comment.
thanks for pointing this out!
aprudhomme
approved these changes
Dec 6, 2024
fragosoluana
deleted the
luanafragoso_add_metrics_hits_logger_backward_compatibility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also support #794 in 0.x versions