Add default terminate after max recall count (#790) #793
+106
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add default terminate after max recall count
aprudhomme
reviewed
Dec 5, 2024
Comment on lines
1106
to
1110
| // If fetch parallelism should be done by groups of fields instead of document, default: false | ||
| google.protobuf.BoolValue parallelFetchByField = 16; | ||
| // The number of documents/fields per parallel fetch task, default: 50 | ||
| google.protobuf.Int32Value parallelFetchChunkSize = 17; | ||
| // Terminate after max recall count value to use when not specified in the search request, or 0 for none, default: 0 |
There was a problem hiding this comment.
You can omit parallelFetchByField and parallelFetchChunkSize. defaultTerminateAfterMaxRecallCount must still use id 18 to match main.
aprudhomme
previously approved these changes
Dec 6, 2024
aprudhomme
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add default terminate after max recall count