Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup lucene server usage #783

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Cleanup lucene server usage #783

merged 3 commits into from
Nov 11, 2024

Conversation

aprudhomme
Copy link
Contributor

Remove references to lucene server from the nrtsearch core.

Much of the changes are removing references from class/local variable names and other strings. Other changes of note:

  • Documentation has been cleaned up
  • Config file names have been cleaned up
  • The nrtsearch_server and nrtsearch_client cli commands have been added so that we can deprecate and remove usage of lucene-server and lucene-client.
  • The LUCENESERVER thread pool has been changed to SERVER

@aprudhomme aprudhomme requested a review from sarthakn7 November 11, 2024 18:53
@aprudhomme aprudhomme merged commit 6a0e537 into Yelp:main Nov 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarthakn7 sarthakn7 sarthakn7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aprudhomme @sarthakn7