Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecated usages #779

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Fix deprecated usages #779

merged 2 commits into from
Nov 7, 2024

Conversation

aprudhomme
Copy link
Contributor

I enabled deprecation warnings and fixed as many as I could.

Notable changes:

  • The ordinals cache for taxonomy facets has been removed. This functionality is completely removed in lucene 10. Taxonomy facets already need to be reworked at some point, since they do not work with nrt distribution.
  • Stored field data loading uses the new lucene interface. A StoredFieldFetchContext is created and used to fetch stored fields by document, after fetching other field types.
  • TimeLimitingCollector was removed, but I don't think it was used anyways.

@aprudhomme aprudhomme requested a review from sarthakn7 November 4, 2024 19:24
@aprudhomme aprudhomme merged commit 1dded2a into Yelp:main Nov 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarthakn7 sarthakn7 sarthakn7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aprudhomme @sarthakn7