Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FieldDefCreatorContext for field creation #778

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

aprudhomme
Copy link
Contributor

Add the context class FieldDefCreatorContext to be used by FieldDef implementations during creation. The context currently only contains NrtsearchConfig, but more items can be added as needed.

@aprudhomme aprudhomme requested a review from sarthakn7 November 1, 2024 22:26
sarthakn7
sarthakn7 previously approved these changes Nov 2, 2024
Copy link
Contributor

@sarthakn7 sarthakn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What else are we planning to add in this context in the future?

@aprudhomme
Copy link
Contributor Author

What else are we planning to add in this context in the future?

I am going to need some changes to the ExecutorFactory so that it will need to be passed to the vector field through this context. We may also need to pass other services in the future, if we move away from static instances.

@aprudhomme aprudhomme requested a review from sarthakn7 November 4, 2024 18:22
@aprudhomme aprudhomme merged commit 5fab5ab into Yelp:main Nov 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants