Expose more server endpoint through cli commands #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarthakn7
reviewed
Oct 24, 2024
| @@ -400,6 +410,28 @@ public List<String> getIndices() { | |||
| .collect(Collectors.toList()); | |||
| } | |||
|
|
|||
| public void nodeInfo() { | |||
There was a problem hiding this comment.
Do we really need these functions in NrtsearchClient? Can we just to client.getBlockingStub().<method> directly in the Command classes? Most of these methods are not reused either.
sarthakn7
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added cli commands missing for endpoints:
I skipped the
stateendpoint for now, since I intend to replace it with a better version. I also skipped the snapshot endpoints, since they likely need to be reworked a bit.