Add nodeInfo grpc endpoint #765
Merged
+1,524
−1,028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarthakn7
reviewed
Oct 16, 2024
| void handleUnaryRequest( | ||
| String name, T protoRequest, StreamObserver<S> responseObserver, Handler<T, S> handler) { | ||
| try { | ||
| handler.handle(protoRequest, responseObserver); |
There was a problem hiding this comment.
If doing this, do you want to add another handle method that returns the response and doesn't need responseObserver? It's currently passed just for error handling.
| assertEquals("serviceName", response.getServiceName()); | ||
| assertEquals("hostName", response.getHostName()); | ||
| assertEquals("ephemeralId", response.getEphemeralId()); | ||
| assertFalse(response.getVersion().isEmpty()); |
There was a problem hiding this comment.
I think you can assert the version to be equal to Version.CURRENT.toString()
sarthakn7
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the grpc endpoint
nodeInfo. This allows you to get the node name, service name, host name, nrtsearch version, and ephemeral id of a running node.I added the utility method
handleUnaryRequestto theHandlerto try to standardize basic error handling and logging for grpc requests. The plan is to migrate more requests to use this in the (near) future.