Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default IndexOptions for text based fields #606

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Fix default IndexOptions for text based fields #606

merged 1 commit into from
Nov 2, 2023

Conversation

aprudhomme
Copy link
Contributor

This change applies to the 1.0.0-SNAPSHOT branch.

The protobuf definition of IndexOptions defaulted to DOCS_FREQS_POSITIONS for TEXT and ATOM fields. I have added a DEFAULT option to the emum, so that ATOM fields can use DOCS and TEXT fields can use DOCS_FREQS_POSITIONS defaults.

@aprudhomme aprudhomme requested a review from sarthakn7 November 1, 2023 21:22
@aprudhomme aprudhomme merged commit 83ee570 into Yelp:1.0.0-SNAPSHOT Nov 2, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarthakn7 sarthakn7 sarthakn7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aprudhomme @sarthakn7