Remove legacy Archiver and backup api #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarthakn7
reviewed
Dec 28, 2023
|
|
||
| @Test | ||
| public void testUploadFile() throws IOException { | ||
| File uploadFile = S3_PROVIDER.getTemporaryFolder().newFile("upload_file"); |
There was a problem hiding this comment.
It seems weird to get TemporaryFolder from S3Provider and use it. Unless someone reads the code, they might just put things in the s3 directory via the TemporaryFolder without meaning to. Maybe just create TemporaryFolder here for this class and remove the getter?
sarthakn7
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the deprecated legacy
Archiverand the legacy backup system in the1.0.0-SNAPSHOTbranch.The
Archiverinterface in general is outdated, and doesn't really fit its usage anymore. I have proposed aRemoteBackendinterface to replace it, which tries to better abstract away the backend implementation from the other nrtsearch components. This interface is used to replace the legacy archiver for warming query interactions.The next steps would be to move the incremental archiver interactions (global state, index state, index data) to use this interface as well. This should make it much easier to make future changes related to backend resource structure.