Update gradle and plugin versions, java 14->17 #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarthakn7
reviewed
Oct 18, 2023
| @@ -41,7 +41,8 @@ public class ReplicationServerClient implements Closeable { | |||
| public static final int FILE_UPDATE_INTERVAL_MS = 10 * 1000; // 10 seconds | |||
|
|
|||
| private static final ObjectMapper OBJECT_MAPPER = | |||
| new ObjectMapper().configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);; | |||
| new ObjectMapper().configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false); | |||
| ; | |||
There was a problem hiding this comment.
This extra semi-colon can be removed
| @@ -101,7 +101,8 @@ public void start() throws IOException { | |||
|
|
|||
| @Override | |||
| public void runBlocking() throws Exception { | |||
| while (visit() == false) ; | |||
| while (visit() == false) | |||
| ; | |||
There was a problem hiding this comment.
This formatting seems weird. I would prefer having the semi-colon in line with while only. If not maybe we can use empty braces.
Comment on lines
+398
to
+399
| collectorsResult | ||
| .get(COLLECTOR_NAME) |
There was a problem hiding this comment.
It looks like the formatter wants toBuilder() on the same line but any other function call in a chain of calls on a different line? Kinda confusing, but I guess we can live with it if it can't be changed.
There was a problem hiding this comment.
Hmm, I guess this is just what spotless does now
sarthakn7
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update build for
1.0.0-SNAPSHOTto use latest gradle/plugin versions. Also, updated java14 references to java17.