Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override lucene BaseFragmentsBuilder to fix a bug #564

Closed

Conversation

waziqi89
Copy link
Contributor

@waziqi89 waziqi89 commented Mar 23, 2023

#567
RP-7664

Fix a bug in lucene core, where the fragment end is calculated wrongly when using discreteMultiValue.

@waziqi89
Copy link
Contributor Author

waziqi89 commented Mar 23, 2023

The changed test basically let the last field to be the best match, then the problem will show up if no such a fix. And the error message looks like

Expecting:
  ["Not all <em>food</em> are good <em>food</em>.",
    "The <em>food</em> is good there, but the service is terrible. I"]
to contain exactly (and in same order):
  ["Not all <em>food</em> are good <em>food</em>.",
    "The <em>food</em> is good there, but the service is terrible."]
but some elements were not found:
  ["The <em>food</em> is good there, but the service is terrible."]
and others were not expected:
  ["The <em>food</em> is good there, but the service is terrible. I"]

Copy link
Contributor

@sarthakn7 sarthakn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ for finding this bug. Can you please create an issue in nrtsearch and then reference that issue number here instead of the ticket number?

@waziqi89
Copy link
Contributor Author

waziqi89 commented Apr 3, 2023

reported to Lucene-core apache/lucene#12221

@sarthakn7 sarthakn7 deleted the branch Yelp:master September 17, 2024 17:56
@sarthakn7 sarthakn7 closed this Sep 17, 2024
@waziqi89 waziqi89 deleted the u/waziqi/RP-7664-fix-fvh-cross-multivalue branch December 13, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants