Fix missingLat typo (#749)

Yelp · Oct 4, 2024 · f4da306 · f4da306
1 parent d1ef31c
commit f4da306
Show file tree

Hide file tree

Showing 7 changed files with 1,753 additions and 1,735 deletions.
diff --git a/clientlib/src/main/proto/yelp/nrtsearch/search.proto b/clientlib/src/main/proto/yelp/nrtsearch/search.proto
@@ -724,7 +724,7 @@ message SortType {
     /* Whether missing values should sort last instead of first.
     Note that this runs \"before\" reverse, so if you sort missing first and reverse=true then missing values will
     be at the end.*/
-    bool missingLat = 4;
+    bool missingLast = 4;
     // Sort in reverse of the field's natural order
     bool reverse = 5;
     // The unit used for the distance sort. Supported options are m, km and mi, default is m

diff --git a/grpc-gateway/luceneserver.pb.go b/grpc-gateway/luceneserver.pb.go
diff --git a/grpc-gateway/luceneserver.swagger.json b/grpc-gateway/luceneserver.swagger.json
@@ -3011,6 +3011,11 @@
           "type": "integer",
           "format": "int32",
           "description": "Position increment gap for indexing multi valued TEXT fields. Must be \u003e= 0, defaulting to 100 when not set."
+        },
+        "ignoreAbove": {
+          "type": "integer",
+          "format": "int32",
+          "title": "For arrays of strings, ignoreAbove will be applied for each array element separately and string elements longer than ignore_above will not be indexed or stored.\nThis option is also useful for protecting against Lucene’s term byte-length limit of 32766"
         }
       }
     },
@@ -4960,7 +4965,7 @@
         "origin": {
           "$ref": "#/definitions/luceneserverPoint"
         },
-        "missingLat": {
+        "missingLast": {
           "type": "boolean",
           "description": "Whether missing values should sort last instead of first.\nNote that this runs \\\"before\\\" reverse, so if you sort missing first and reverse=true then missing values will\nbe at the end."
         },

diff --git a/grpc-gateway/search.pb.go b/grpc-gateway/search.pb.go
diff --git a/src/main/java/com/yelp/nrtsearch/server/luceneserver/field/AtomFieldDef.java b/src/main/java/com/yelp/nrtsearch/server/luceneserver/field/AtomFieldDef.java
@@ -89,7 +89,7 @@ public SortField getSortField(SortType type) {
       sortField = new SortField(getName(), SortField.Type.STRING, type.getReverse());
     }
 
-    boolean missingLast = type.getMissingLat();
+    boolean missingLast = type.getMissingLast();
     if (missingLast) {
       sortField.setMissingValue(SortField.STRING_LAST);
     } else {

diff --git a/src/main/java/com/yelp/nrtsearch/server/luceneserver/field/DateTimeFieldDef.java b/src/main/java/com/yelp/nrtsearch/server/luceneserver/field/DateTimeFieldDef.java
@@ -94,7 +94,7 @@ public SortField getSortField(SortType type) {
       throw new IllegalStateException("DATE_TIME does not support sort for multi value field");
     }
     SortField sortField = new SortField(getName(), SortField.Type.LONG, type.getReverse());
-    boolean missingLast = type.getMissingLat();
+    boolean missingLast = type.getMissingLast();
     sortField.setMissingValue(missingLast ? Long.MAX_VALUE : Long.MIN_VALUE);
     return sortField;
   }

diff --git a/src/main/java/com/yelp/nrtsearch/server/luceneserver/field/NumberFieldDef.java b/src/main/java/com/yelp/nrtsearch/server/luceneserver/field/NumberFieldDef.java
@@ -280,7 +280,7 @@ public SortField getSortField(SortType type) {
       sortField = new SortField(getName(), getSortFieldType(), type.getReverse());
     }
 
-    boolean missingLast = type.getMissingLat();
+    boolean missingLast = type.getMissingLast();
     sortField.setMissingValue(getSortMissingValue(missingLast));
     return sortField;
   }