add DEFAULT_FORMATS['uuid'] in formatter.py #374
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjaensch
suggested changes
Mar 9, 2020
Contributor
sjaensch
left a comment
sjaensch
left a comment
There was a problem hiding this comment.
You have a travis failure; please run make install-hooks locally to see and fix the issue.
| format='byte', | ||
| to_wire=lambda u: str(u) if isinstance(u, uuid.UUID) else u, | ||
| to_python=lambda s: s if isinstance(s, uuid.UUID) else uuid.UUID(s), | ||
| validate=NO_OP, # jsonschema validates uuid |
Contributor
There was a problem hiding this comment.
I don't think JSONSchema does validate UUID, does it?
I'm also hesitant to add a default format to bravado-core that is not defined in the OpenAPI specification. If we do add it, could you please mention it in the documentation as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.