[TNT-103] 로그인 화면 UI 구현 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 실제 이동은 아직 회원가입 화면의 네비게이션 경로를 알 수 없기 때문에 미구현
SeonJeongk
approved these changes
Jan 20, 2025
Comment on lines
+172
to
+175
| Text( | ||
| text = stringResource(R.string.continue_with_kakao), | ||
| style = TnTTheme.typography.body1Medium, | ||
| ) |
There was a problem hiding this comment.
요기 글자 세로 중앙 정렬 안 맞습니다 !-!
There was a problem hiding this comment.
꼼꼼하게 봐주셔서 감사합니다 :)
Comment on lines
+3
to
+5
| <string name="nice_to_meet_you">만나서 반가워요!</string> | ||
| <string name="trainer_trainee_chemistry_boom">트레이너와 트레이니\n케미 터트리기</string> | ||
| <string name="continue_with_kakao">카카오로 계속하기</string> |
There was a problem hiding this comment.
옹 스트링 리소스 이름 지으실 때 내용 기반으로 하시나요?
저는 보통 해당 문자열이 쓰이는 화면에서의 역할과 연관 지어서 아래처럼 작성했습니다!
<string name="login_title">만나서 반가워요!</string>
<string name="login_subtitle">트레이너와 트레이니\n케미 터트리기</string>
모듈 별로 strings를 따로 관리해야 한다고 하니 내용 기반으로 네이밍하는 방식이 직관적이고 좋을 것 같네요!
회원가입 모듈 분리하면서 이름도 수정해보겠습니다
There was a problem hiding this comment.
넵넵 사실 앞에 사용하는 '화면' 을 명시하게 되면 그 화면 내에서만 쓸 수 있도록 강제되는 면이 있어서
저는 개인적으로 내용 기반으로 작성하는 편입니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
TnTModalBottomSheetTnTDivider📸 실행 화면
default.mp4
🙆🏻 리뷰 요청 사항
👀 레퍼런스