[AutoBump] Merge with fixes of 86dbaf04 (Jan 08) (3) #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Below is the list of folks (alphabetically listed) who contributed code in the private repo. Thanks to all for your outstanding contributions. Co-authored-by: Alexandre Eichenberger <[email protected]> Co-authored-by: Christopher Munoz <[email protected]> Co-authored-by: Gong Su <[email protected]> Co-authored-by: Haruki Imai <[email protected]> Co-authored-by: Megan Hampton <[email protected]> Co-authored-by: Mike Essenmacher <[email protected]> Co-authored-by: Sunny Anand <[email protected]> Co-authored-by: Tong Chen <[email protected]> Co-authored-by: Tung D. Le <[email protected]> Co-authored-by: Yasushi Negishi <[email protected]> Signed-off-by: Alexandre Eichenberger <[email protected]>
jorickert
commented
Jan 30, 2025
| @@ -160,11 +161,35 @@ std::string getTargetTripleOption(); | |||
|
|
|||
| void setTargetArch(const std::string &arch); | |||
| void clearTargetArch(); | |||
| std::string getTargetArchOption(); | |||
|
|
|||
| // AMD: inlined to avoid linking errors | |||
There was a problem hiding this comment.
We get linker errors in downstream components when linking the CompilerOptions to more than one other library. As another library started to use getZArchNum I inlined the function to work around this issue.
If the compiler options get more widely used, we should figure out the root cause of the linking problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.