Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added specific SKIPPED message for step_qonnx_to_finn #110

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

penrosed
Copy link
Collaborator

@penrosed penrosed commented Jan 6, 2025

Compiled a list of models that are already in the FINN-ONNX format, as "step_qonnx_to_finn" skips these models. If we're running that step on one of those models, we can tell the user WHY it was skipped.

Compiled a list of models that are already in the FINN-ONNX format, as "step_qonnx_to_finn" skips these models. If we're running that step on one of those models, we can tell the user WHY it was skipped.
@penrosed penrosed requested a review from auphelia January 6, 2025 16:46
All files here were automatically modified by running the repo's pre-commit hooks locally in a virtual environment. The setup for these hooks is found in pre-commit.yaml
Copy link
Collaborator

@auphelia auphelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @penrosed

@penrosed penrosed merged commit bfe4e9b into dev Jan 7, 2025
1 check passed
@penrosed penrosed deleted the feature/validation_steps_clean branch January 7, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants