Feature/validation steps (clean) #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added files for validating finn-examples builds
Build verification by appending to Python sys.path and importing functions
…y13/finn-examples into feature/validation_steps
Clean up verification build files
auphelia
reviewed
Nov 15, 2024
auphelia
reviewed
Nov 15, 2024
auphelia
reviewed
Nov 15, 2024
auphelia
reviewed
Nov 15, 2024
auphelia
reviewed
Nov 15, 2024
auphelia
reviewed
Nov 15, 2024
auphelia
reviewed
Nov 15, 2024
auphelia
reviewed
Nov 15, 2024
…step - Removed "custom_step_update_model" from the GTSRB, MobileNet-v1, ResNet50, and RadioML build scripts. Also removed equivalent code from the KWS build script. - In GTSRB build script, renamed "step_preprocess" to "custom_step_add_postproc", and updated how it gets called in the script's custom_build_steps. - In the MobileNet-v1 build script, "step_create_stitched_ip" was added to the build steps, so that the build script can use the step's stitched IP RTL simulation. Co-Authored-By: auphelia <[email protected]>
"SKIPPED" implies a verification step was intentionally skipped, rather than the input-output .npy file not being found. The console output now reads "IO FILLE NOT FOUND - SKIPPED" instead.
- in `build/mobilenet-v1/build.py`, the model name it was trying to fetch was outdated, and didn't reflect the most recent model released (opset-11). - In the README of `build/vgg10-radioml`, the path provided to run the build script was incorrect.
`ModelWrapper`, `onnx`, and (in gtsrb's case) `build_dataflow_step_lookup` are not called now that the update step has been removed.
The linting Action in the repo flagged this section of code as failing its lint check. Resolved.
penrosed
commented
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After my bad commits on
feature/validation_steps, which git seemed to think had not made any changes at all, and thus couldn't be reverted, a new branch was made,feature/validation_steps_clean, based on the branch as it was before the bad commits. This pull request replaces the one made onfeature/validation_steps.