Feature/new theme generation

[Thunder-Blaze]

📝 Description

• A new methord to sort out and choose colors for color theme.
• Needs more Reworking as of right now (especially fully dark mode)
• Have yet to add feature of storing theme in local storage

📸 Screenshots / 📹 Videos

• Will add more when I finish
  

🔗 Related Issues

• None ig
• But might be able to add custom color feature soon (with local storage and all)

✅ Checklist

• I have read and followed the Contributing Guidelines.
• I have tested my changes by installing them as an extension (not just running via localhost) to ensure it builds, installs, and works as expected.
• I have tested these changes in at least Chrome and Firefox (other browsers if applicable).
• Attached visual evidence of changes (screenshots or videos) if applicable.

[prem-k-r]

conflicts
relavant part


and rename of Grey to Peach

[prem-k-r]

Resolved conflicts

[prem-k-r]

I just checked. Umm... wouldn't only modifying the color picker be enough?

[Thunder-Blaze]

Resolved conflicts

Thank u sm, I was thinking to do those changes when I finished working on popup UI

I just checked. Umm... wouldn't only modifying the color picker be enough?

Well yeah i guess, but all that dark theme css was almost unneeded
After I finish all the changes, I think there will be only be about 5 lines that will be needed (for the same darkmode) and we can add them in css imo

[Thunder-Blaze]

I'll try to finish tonight

[prem-k-r]

And what about other themes, they are just color values in your pr.
They are changing shades according to color picker code.
Are they temporary for testing?

[Thunder-Blaze]

And what about other themes, they are just color values in your pr. They are changing shades according to color picker code. Are they temporary for testing?

I was trying out eliminating the extra CSS vars but results are not that good so will prob switch back to the old methord for those colors
(Old methord refers to replacing the blue CSS vars to the selected color vars)

[Thunder-Blaze]

sorry haven't been able to work on this bcoz of recent assignments
am on it now

[prem-k-r]

no worry bro, take as much as time
I have done some theme related changes :(
#508 #511 #512

[Thunder-Blaze]

no worry bro, take as much as time I have done some theme related changes :( #508 #511 #512

well dw I'll push my pr after properly merging yours 👍🏻
though #508 will probably become useless

• Now have to work on material design modal
• save theme to local storage
• and the sun moon toggle

[prem-k-r]

• and the sun moon toggle

https://uiverse.io/Creatlydev/massive-quail-70
https://uiverse.io/catraco/brown-termite-67
and in this website's code section too there is a toggle lol

[itz-rj-here]

This one is way better.

We can just place it here.

[prem-k-r]

<svg class="moon" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 384 512">
    <path fill="blue"
        d="M223.5 32C100 32 0 132.3 0 256S100 480 223.5 480c60.6 0 115.5-24.2 155.8-63.4c5-4.9 6.3-12.5 3.1-18.7s-10.1-9.7-17-8.5c-9.8 1.7-19.8 2.6-30.1 2.6c-96.9 0-175.5-78.8-175.5-176c0-65.8 36-123.1 89.3-153.3c6.1-3.5 9.2-10.5 7.7-17.3s-7.3-11.9-14.3-12.5c-6.3-.5-12.6-.8-19-.8z" />
</svg>
<svg class="sun" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512">
    <path fill="blue"
        d="M361.5 1.2c5 2.1 8.6 6.6 9.6 11.9L391 121l107.9 19.8c5.3 1 9.8 4.6 11.9 9.6s1.5 10.7-1.6 15.2L446.9 256l62.3 90.3c3.1 4.5 3.7 10.2 1.6 15.2s-6.6 8.6-11.9 9.6L391 391 371.1 498.9c-1 5.3-4.6 9.8-9.6 11.9s-10.7 1.5-15.2-1.6L256 446.9l-90.3 62.3c-4.5 3.1-10.2 3.7-15.2 1.6s-8.6-6.6-9.6-11.9L121 391 13.1 371.1c-5.3-1-9.8-4.6-11.9-9.6s-1.5-10.7 1.6-15.2L65.1 256 2.8 165.7c-3.1-4.5-3.7-10.2-1.6-15.2s6.6-8.6 11.9-9.6L121 121 140.9 13.1c1-5.3 4.6-9.8 9.6-11.9s10.7-1.5 15.2 1.6L256 65.1 346.3 2.8c4.5-3.1 10.2-3.7 15.2-1.6zM160 256a96 96 0 1 1 192 0 96 96 0 1 1 -192 0zm224 0a128 128 0 1 0 -256 0 128 128 0 1 0 256 0z" />
</svg>

[Thunder-Blaze]

Thanks @itz-rj-here @prem-k-r
toggle done 👍🏻

About the Custom themes, should I allow users to have multiple saved custom themes or only one ?

[itz-rj-here]

Thanks @itz-rj-here @prem-k-r
toggle done 👍🏻

About the Custom themes, should I allow users to have multiple saved custom themes or only one ?

Ig ask @XengShi about it...

[prem-k-r]

more will be better ig, but depends on how it looks

@Thunder-Blaze can you please change deployment branch from responsiveness one to this one

[Thunder-Blaze]

more will be better ig, but depends on how it looks

@Thunder-Blaze can you please change deployment branch from responsiveness one to this one

Yeah sure, will do it tonight 👍🏻

[prem-k-r]

Wow, awesome! Great work 👍🏻
Much better now

[Thunder-Blaze]

Wow, awesome! Great work 👍🏻 Much better now

Thanks :D
It's live here https://thunder-blaze.github.io/MaterialYou-NewTab/
I think almost all errors are fixed now, just have to work on the custom theme option
(I mean there is one error (Favicons are not retained on refresh), but rather than fixing it now, I'll fix it after merging your custom Favicon pr as it will be much easier then)

[itz-rj-here]

Ig the dark mode and light mode setup is wrong. In light mode the button should show sun
And in dark mode the button should show the moon.
Its kind of reversed.

[prem-k-r]

Not really wrong. That's how it intended to. It's better this way I think.

[itz-rj-here]

@prem-k-r I just shared my thoughts. As you think.

[Thunder-Blaze]

@XengShi @prem-k-r @itz-rj-here I pushed the popup, please check it and lmk what you guys think

[prem-k-r]

Awesome! Functionality is nice

[prem-k-r]

Can you please change the names and order
Primary Color | Secondary Color
Background Color | Accent Color
Text Color | Highlight Color

And change pick color position
Maybe XengShi can suggest a design