modesetting: Track both the map data and address for gpu buffers #1757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan11111
requested review from
a team,
algrid,
callmetango,
cepelinas9000 and
metux
Contributor
Author
|
@notbabaisyou ping |
3 tasks
stefan11111
changed the title
Signed-off-by: stefan11111 <[email protected]>
Signed-off-by: stefan11111 <[email protected]>
Same as what we use in glamor/glamor_egl.c Signed-off-by: stefan11111 <[email protected]>
stefan11111
force-pushed
the
map-buffers-immediately
branch
from
1a314f2 to
cadb8b5
Compare
Contributor
Author
algrid
reviewed
Jan 5, 2026
| #endif | ||
| void* map; | ||
| void* map_data; /* Actual pixel data we are interesed in */ | ||
| void* map_addr; /* Address of the map that we have to unmap */ |
There was a problem hiding this comment.
Would it make sense to move the map_addr definition into the ifdef above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/39097 , and to the links I posted there, we need 2 pointers to track buffer maps, not just one.