Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ngx-mapbox-gl to support zoneless change detection #426 #427

Closed
wants to merge 14 commits into from
Closed

Refactor ngx-mapbox-gl to support zoneless change detection #426 #427

wants to merge 14 commits into from

Conversation

denisyilmaz
Copy link

  • Updated ngx-mapbox-glto be compatible with Angular’s zoneless change detection by using provideExperimentalZonelessChangeDetection().
  • Removed reliance on zone.onStable as it no longer functions with zoneless mode.
  • Replaced zone.onStable with afterNextRender() to handle post-render tasks, aligning with the new zoneless change detection strategy.

References #424

sandikbarr and others added 14 commits September 10, 2024 07:36
@sandikbarr @denisyilmaz
fix: set baseApiUrl rather than assign config.API_URL which is now a …
f3dff95 
…getter (Wykks#395)
@Wykks @denisyilmaz
ci: Update yarn
f15ca7b
@Wykks @denisyilmaz
refactor: update to angular 16 with nx migrate
6dbf5fa
@Wykks @denisyilmaz
ci: update workflow
60a16a4
@Wykks @denisyilmaz
test: fix test
b07f2d2
@Wykks @denisyilmaz
fix: adjust package json compat
f4e35ae 
BREAKING CHANGE: Updated to Angular 16
@Wykks @denisyilmaz
chore(release): 10.0.0
3be54f6
@Wykks @denisyilmaz
doc: update README
58f540a
@harellevy @denisyilmaz
Update map.service.ts (Wykks#408)
67a60e6 
fixing es-build angular 16 build with error
```
Cannot assign to import "baseApiUrl"

    node_modules/ngx-mapbox-gl/fesm2022/ngx-mapbox-gl.mjs:34:25:
      34 │                 MapboxGl.baseApiUrl = options.customMapboxApiUrl;
         ╵                          ~~~~~~~~~~

  Imports are immutable in JavaScript. To modify the value of this import
```
related to evanw/esbuild#891,



fixes:
Wykks#403
Wykks#407
@luigi-iss @denisyilmaz
feat: Upgrade to Angular 18 (Wykks#417 Wykks#418) (Wykks#420)
55d465d 
* (fix) Added esModuleInterop tsconfig

* (feat) Upgraded to angular 18

* Updated browser list

* Fixing filter

* Updated some dependencies

* Upgraded jest

* Upgraded angular ngrx eslint

* Upgraded CI to use v0.15 of the nrwl workflows

* Bumped package version to 11 and updated readme

BREAKING CHANGE: Updated to Angular 18
@Wykks @denisyilmaz
chore(release): 11.0.0
10506e5
@Wykks @denisyilmaz
fix: update package peerDependencies
ed4db88
@Wykks @denisyilmaz
chore(release): 11.0.1
35f6e85
@denisyilmaz
Refactor ngx-mapbox-gl to support zoneless change detection
fcbfb94
@denisyilmaz denisyilmaz deleted the feature/allow-experimental-zoneless-configuration branch September 24, 2024 06:46
@denisyilmaz denisyilmaz mentioned this pull request Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@denisyilmaz @sandikbarr @Wykks @harellevy @luigi-iss