Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix minior bugs + remove useless import #136

Merged
merged 4 commits into from
Apr 19, 2024
Merged

fix minior bugs + remove useless import #136

merged 4 commits into from
Apr 19, 2024

Conversation

driver005
Copy link
Contributor

No description provided.

@hasezoey
Copy link
Collaborator

note that the "unused dsl import" had already a PR at #134

@driver005
Copy link
Contributor Author

fell free to revese it
but the other changes are crutal for async fn

@hasezoey
Copy link
Collaborator

hasezoey commented Apr 19, 2024

fell free to revese it

i just wanted to note that the change had already been suggested previously, i have nothing against using it
(note that i am a collaborator, but thanks to a branch protection rule i cannot merge my own PRs without another collaborators approval)

Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the test files, see Development/Testing, see failing tests.
(preferably put those changed tests into the commits that changed them)

also it would be great if there could be a test and compile-test for the async paginate (that does not particularly need to be in this PR)

@driver005
Copy link
Contributor Author

oke i will reverse the change to unused dsl import becuase of #134
it would be great if someone adds the test

@driver005 driver005 requested a review from hasezoey April 19, 2024 11:51
Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok now, personally i would have liked if the commit messages would follow the style of past commits, though wont a problem here because i will squash it.
(i know that we currently dont have a CONTRIBUTING file)

@hasezoey hasezoey merged commit 07f2268 into Wulf:main Apr 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants