-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix minior bugs + remove useless import #136
Conversation
note that the "unused dsl import" had already a PR at #134 |
fell free to revese it |
i just wanted to note that the change had already been suggested previously, i have nothing against using it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update the test files, see Development/Testing, see failing tests.
(preferably put those changed tests into the commits that changed them)
also it would be great if there could be a test and compile-test for the async paginate (that does not particularly need to be in this PR)
oke i will reverse the change to unused dsl import becuase of #134 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok now, personally i would have liked if the commit messages would follow the style of past commits, though wont a problem here because i will squash it.
(i know that we currently dont have a CONTRIBUTING file)
No description provided.