Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URGENT PATCH: Fixed critical security issue in C2S_UpdateItemStack packet #50

Open
wants to merge 1 commit into
base: 1.20-architectury
Choose a base branch
from
Open

URGENT PATCH: Fixed critical security issue in C2S_UpdateItemStack packet #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions common/src/main/java/io/github/wouink/furnish/network/C2S_UpdateItemStack.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import dev.architectury.networking.simple.BaseC2SMessage;
import dev.architectury.networking.simple.MessageType;
import io.github.wouink.furnish.Furnish;
import io.github.wouink.furnish.item.Letter;
import net.minecraft.network.FriendlyByteBuf;
import net.minecraft.world.item.ItemStack;

Expand Down Expand Up @@ -46,8 +47,13 @@ public void write(FriendlyByteBuf buf) {
@Override
public void handle(NetworkManager.PacketContext context) {
context.queue(() -> {
context.getPlayer().getInventory().setItem(slot, newStack);
context.getPlayer().getInventory().setChanged();
/**
PATCH: Fixed security vulnerability allowing arbitrary spawning of items in this packet by ensuring proper validation.
**/
if (newStack.getItem() instanceof Letter) {
context.getPlayer().getInventory().setItem(slot, newStack);
context.getPlayer().getInventory().setChanged();
}
});
}
}
}