Skip to content

Conversation

@mannycarrera4
Copy link
Contributor

@mannycarrera4 mannycarrera4 commented Dec 11, 2025

Summary

Fixes: #3603

Release Category

Documentation

Release Note

The following have been updated:

  • Added more tooling and docs to our MCP to better support information around older Canvas Kit versions as well as our tokens and migrations
  • Updated our theming docs to be more prescriptive
  • Updated our messaging around the theme prop where it should only be used for scoped theming purposes.
  • Added markdown files to our docs directory for consumers to use/reference if need be

Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Testing Manually

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

@cypress
Copy link

cypress bot commented Dec 11, 2025

Workday/canvas-kit    Run #9896

Run Properties:  status check passed Passed #9896  •  git commit 6dc8720f7d ℹ️: Merge 35ce9d3b3ac1bc51fb061461d5908552e7bd9348 into 875ae599f06ce7abbef4e7b437d5...
Project Workday/canvas-kit
Branch Review mc-mcp-theme-feat
Run status status check passed Passed #9896
Run duration 02m 26s
Commit git commit 6dc8720f7d ℹ️: Merge 35ce9d3b3ac1bc51fb061461d5908552e7bd9348 into 875ae599f06ce7abbef4e7b437d5...
Committer Manuel Carrera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 86
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 843
View all changes introduced in this branch ↗︎
UI Coverage  19.3%
  Untested elements 1537  
  Tested elements 365  
Accessibility  99.31%
  Failed rules  6 critical   5 serious   0 moderate   2 minor
  Failed elements 77  

@RayRedGoose RayRedGoose requested a review from Copilot December 11, 2025 18:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances Canvas Kit's documentation infrastructure by adding comprehensive markdown versions of MDX documentation and expanding the MCP (Model Context Protocol) tooling to better support LLM-based documentation access and code assistance.

Key Changes:

  • Added markdown documentation exports for tokens migration, style props migration, and accessibility guides
  • Enhanced MCP with versioning information, token/migration documentation, and theming guidance
  • Updated theming documentation to be more prescriptive about the theme prop usage

Reviewed changes

Copilot reviewed 62 out of 166 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
modules/docs/llm/markdown/docs/mdx/tokens/*.md Token migration mapping tables and guides for system, color, and installation documentation
modules/docs/llm/markdown/docs/mdx/style-props/*.md Style props migration guides, codemod documentation, and overview of deprecated features
modules/docs/llm/markdown/docs/mdx/accessibility/*.md Accessibility guides including ARIA live regions, page structure, tables, and testing examples
modules/docs/llm/markdown/docs/mdx/*.md Core documentation files for changelog, versions, testing, packages, maintaining, getting started, documentation guidelines, compound components, and contributing
mdx2md/package.json Package configuration for MDX to Markdown converter tool
Comments suppressed due to low confidence (2)

modules/docs/llm/markdown/docs/mdx/tokens/TokenMigrationMappingSystem.md:1

  • Corrected spelling of 'positio' to 'position'.
---

modules/docs/llm/markdown/docs/mdx/tokens/TokenMigrationInstall.md:1

  • Corrected spelling of 'automatially' to 'automatically'.
---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


- checkout the repository
- install dependencies (if they are not already cached)
- run `yarn bump` to craete a commit and a git tag
Copy link

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'craete' to 'create'.

Suggested change
- run `yarn bump` to craete a commit and a git tag
- run `yarn bump` to create a commit and a git tag

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant