chore: Upgrade Storybook to vite #3622
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… chore/upgrade-storybook-to-vite # Conflicts: # .nvmrc # modules/docs/lib/MDXElements.tsx # modules/docs/lib/Value.tsx # modules/docs/mdx/14.0-UPGRADE-GUIDE.mdx # modules/styling-transform/package.json # package.json # yarn.lock
NicholasBoll
commented
Dec 3, 2025
Comment on lines
+103
to
+107
| cy.realPress('Tab'); | ||
| cy.focused().should('contain', 'Acknowledge'); | ||
| cy.realPress('Tab'); | ||
| cy.focused().should('contain', 'Cancel'); | ||
| cy.realPress('Tab'); |
Collaborator
Author
There was a problem hiding this comment.
cy.tab doesn't work with something. cy.realPress doesn't return the subject.
NicholasBoll
commented
Dec 3, 2025
Comment on lines
+115
to
+119
| cy.realPress('Tab'); | ||
| .should('contain', 'Cancel') | ||
| .tab() | ||
| .realPress('Tab'); | ||
| .should('contain', 'Delete Item') | ||
| .tab(); | ||
| .realPress('Tab'); |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| cy.realPress('Tab'); | |
| .should('contain', 'Cancel') | |
| .tab() | |
| .realPress('Tab'); | |
| .should('contain', 'Delete Item') | |
| .tab(); | |
| .realPress('Tab'); | |
| cy.realPress('Tab'); | |
| cy.focused().should('contain', 'Cancel'); | |
| cy.realPress('Tab'); | |
| cy.focused().should('contain', 'Delete Item'); | |
| cy.realPress('Tab'); |
NicholasBoll
commented
Dec 3, 2025
NicholasBoll
commented
Dec 3, 2025
Comment on lines
6
to
8
| // declare module 'vite' { | ||
| // export function defineConfig(config: any): any; | ||
| // } |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| // declare module 'vite' { | |
| // export function defineConfig(config: any): any; | |
| // } |
Contributor
|
future change: Change storybook files to not re exported the renamed story |
Contributor
|
NB: Update cypress specification path for ` |
NicholasBoll
commented
Dec 4, 2025
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
chore/upgrade-storybook-to-vite
|
| Run status |
|
| Run duration | 02m 30s |
| Commit |
|
| Committer | Nicholas Boll |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
19
|
Skipped
|
0
|
Passing
|
910
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
19.61%
|
|
|---|---|
|
Untested elements
|
1531
|
|
Tested elements
|
371
|
Accessibility
99.26%
|
|
|---|---|
|
Failed rules
|
6 critical
5 serious
0 moderate
2 minor
|
|
Failed elements
|
95
|
8 tasks
Co-authored-by: Nicholas Boll <[email protected]>
Co-authored-by: Nicholas Boll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Convert Storybook from webpack to vite
Release Category
Infrastructure
Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Run
yarn start,yarn test,yarn cypress:run