Update wp_parse_url() for performance and legacy code removal #7743
Conversation
With the current supported PHP, it's no longer necessary to use this function's code to mitigate PHP incompatibility. This change aims to remove the legacy fix and improve performance. Functions `_get_component_from_parsed_url_array()` and `_wp_translate_php_url_constant_to_key()` are not required for the new version of the function
Update wp_parse_url() for performance and legacy code removal With the current supported PHP version, this function's code is no longer necessary to mitigate PHP native function incompatibility. This change aims to remove the legacy fix and improve performance. Functions `_get_component_from_parsed_url_array()` and `_wp_translate_php_url_constant_to_key()` are not required for the new version of the function, and should be remeoved.
|
Hi @WpSpeedDoctor! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
src/wp-includes/http.php
Outdated
|
|
||
| $parts = parse_url( $url ); | ||
| case -1: | ||
| return parse_url( (string) $url ); |
There was a problem hiding this comment.
You use the typecast (string) here and again at the bottom.
I'd either normalize $url before the switch or simply set $component = null; and use the single return at the end to reduce redundancy here.
For case -1: was removed return as `-1` of $component is the default value anyway, `null` value is deprecated so it's better to continue the case and return on the end. I kept typecast `(string) $url` as it's commonly used in WP core code and it's not listed as a bad practice in PHP coding standards. Now this should be a performance update, I don't want to declare a new variable like `$string_url=strval($url)` or assign `$url = strval($url);`, from the performance point of view, it's an unnecessary step, this hardly will add to readability.
Update wp_parse_url() for performance and legacy code removal
With the current supported PHP, it's no longer necessary to use this function's code to mitigate PHP incompatibility. This change aims to remove the legacy fix and improve performance.
Functions "_get_component_from_parsed_url_array()" and "_wp_translate_php_url_constant_to_key()" are not required for the new version of the function
Trac ticket:
https://core.trac.wordpress.org/ticket/62124
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.