Skip to content

Comments

Fix PHPStan undefined variables in menu.php and network.php#11014

Open
huzaifaalmesbah wants to merge 1 commit intoWordPress:trunkfrom
huzaifaalmesbah:fix/phpstan-menu-network
Open

Fix PHPStan undefined variables in menu.php and network.php#11014
huzaifaalmesbah wants to merge 1 commit intoWordPress:trunkfrom
huzaifaalmesbah:fix/phpstan-menu-network

Conversation

@huzaifaalmesbah
Copy link
Member

This fixes a few PHPStan "variable might not be defined" warnings..
Changes:

  • src/wp-admin/includes/menu.php: Added the global declaration for $menu, $submenu, and $compat.
  • src/wp-admin/includes/network.php: Initialized the $message and $message_class variables to prevent them from being undefined when the condition isn't met.

Trac: https://core.trac.wordpress.org/ticket/64238

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props huzaifaalmesbah.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

}

// Create list of page plugin hook names.
global $menu, $submenu, $compat;
Copy link

@noruzzamans noruzzamans Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch on the PHPStan warnings!

Quick question:
since wp-admin/menu.php (line 440) loads includes/menu.php via require, both files share the same scope. So $menu, $submenu, and $compat should already be accessible without global.
Do you think PHPStan is flagging this because it analyzes the file in isolation? Just curious about the reasoning. The network.php fix looks solid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants