Skip to content

Comments

Docs: Replace void with null in union return types in class-wpdb.php#11009

Open
apermo wants to merge 4 commits intoWordPress:trunkfrom
apermo:trac-64703
Open

Docs: Replace void with null in union return types in class-wpdb.php#11009
apermo wants to merge 4 commits intoWordPress:trunkfrom
apermo:trac-64703

Conversation

@apermo
Copy link

@apermo apermo commented Feb 23, 2026

Co-Authored-By: xateman

Trac ticket: https://core.trac.wordpress.org/ticket/64703

Use of AI Tools

Used AI for research, documentation and for the replacements. Everything was reviewed by myself and @xateman before opening this PR.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Fixes #64703.
See #64694.

Co-Authored-By: xateman
Copy link

@xateman xateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@github-actions
Copy link

github-actions bot commented Feb 23, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props apermo, xate, mukesh27, westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

PHPStan cannot verify that wp_die() always
terminates due to its conditional return type
and treatPhpDocTypesAsCertain being disabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants