Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern review: CTA Pricing, clients and banner with description patterns. #343

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Sep 17, 2024

Description

Partial to #302

  • CTA Pricing pattern: Removed padding and used spacer instead.
  • Clients: Removed padding and used spacer instead. Switched heading from H3 to H2 to match design.
  • Banner with description: Set minimum column width to 26.

Screenshots

N/A

Testing Instructions

CTA pricing pattern

  1. Create a page.
  2. Use the CTA pricing pattern.
  3. Confirm the padding is no longer there for the stack and we're using a spacer instead.

Clients pattern

  1. Create a page
  2. Use the clients pattern.
  3. Confirm that we're no longer using padding and we are now using a spacer.
  4. As a bonus, the H3 is now an H2, to respect the Figma design.

Banner with description

  1. Create a page.
  2. Use the "Banner with description and images grid"
  3. Confirm that the grid minimum col width is set to 26.

@juanfra juanfra added the [Type] Enhancement A suggestion for improvement. label Sep 17, 2024
Copy link

github-actions bot commented Sep 17, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Sep 20, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@carolinan carolinan merged commit 4074082 into trunk Sep 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants