-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fine tuning adjustments to default header and footer #340
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a block validation error in this header.
There is a group that is incomplete or not closed.
I tried to change only what was necessary so I wouldn't touch the code, but I guess I missed something. I submitted another change to the footer to hopefully fix that. |
The problem with the broken group block is in the header, not the footer. I'll try to help another time when I am more alert :) |
Oops 🙈 this is what happens when the designer touches code. The only thing I wanted to change in the header was to set the top and bottom spacing of the row to Thank you for the help, no urgency! |
Preview changesYou can preview these changes by following the link below: I will update this comment with the latest preview links as you push more changes to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Bea!
I've fixed the block validation issue and worked on the indent of the footer.
Looks good to me
Description
Fine-tuning adjustments to the default header and footer:
M
instead ofS
font size in theme.json