Fix livelock on IN or OUT transactions #13
Conversation
RockyZeroFour
commented
Dec 8, 2024
RockyZeroFour
commented
- Handles new interrupt flags for IN & OUT endpoints
- Catches interrupts when certain error conditions occured
- Prevents livelocks for some error conditions
- Handles new interrupt flags for IN & OUT endpoints - Catches interrupts when certain error conditions occured - Prevents livelocks for some error conditions
| @@ -1348,7 +1354,7 @@ void dcd_int_handler(uint8_t rhport) | |||
| do | |||
| { | |||
| handle_rxflvl_irq(rhport); | |||
| } while(dwc2->gotgint & GINTSTS_RXFLVL); | |||
| } while(dwc2->gintsts & GINTSTS_RXFLVL); | |||
There was a problem hiding this comment.
This change is kinda confusing, howcome it was like this before? Is this change valid for gd32 & stm32?
There was a problem hiding this comment.
That was a bug, likely because of a typo. The goal here is to remain in the FIFO handler until the FIFO is empty and the interrupt is then automatically cleared again. Before the handler would be triggered again until the FIFO is empty instead of staying there until done as intended.
During a code check I noticed that this was off so I looked closer. Checking the global OTG interrupt flag register (gotgint) isn't related to the FIFO so using that don't make sense, the naming of the bit also indicate that it's not supposed to be used with that register and a quick check on the current TinyUSB branch revealed that they also changed it.
