Log exception when (static) mapping file cannot be read (#1202)

WireMock-Net · Oct 29, 2024 · 3693d6a · 3693d6a
1 parent 214fb53
commit 3693d6a
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/src/WireMock.Net.Abstractions/Logging/IWireMockLogger.cs b/src/WireMock.Net.Abstractions/Logging/IWireMockLogger.cs
@@ -51,10 +51,10 @@ public interface IWireMockLogger
     /// <summary>
     /// Writes the message at the Error level using the specified exception. 
     /// </summary>
-    /// <param name="formatString">The format string.</param>
+    /// <param name="message">The message.</param>
     /// <param name="exception">The exception.</param>
     [PublicAPI]
-    void Error(string formatString, Exception exception);
+    void Error(string message, Exception exception);
 
     /// <summary>
     /// Writes the LogEntryModel (LogRequestModel, LogResponseModel and more).

diff --git a/src/WireMock.Net/Logging/WireMockConsoleLogger.cs b/src/WireMock.Net/Logging/WireMockConsoleLogger.cs
@@ -52,9 +52,9 @@ public void Error(string formatString, params object[] args)
     }
 
     /// <see cref="IWireMockLogger.Error(string, Exception)"/>
-    public void Error(string formatString, Exception exception)
+    public void Error(string message, Exception exception)
     {
-        Console.WriteLine(Format("Error", formatString, exception.Message));
+        Console.WriteLine(Format("Error", $"{message} {{0}}", exception.Message));
 
         if (exception is AggregateException ae)
         {

diff --git a/src/WireMock.Net/Logging/WireMockNullLogger.cs b/src/WireMock.Net/Logging/WireMockNullLogger.cs
@@ -36,7 +36,7 @@ public void Error(string formatString, params object[] args)
     }
 
     /// <see cref="IWireMockLogger.Error(string, Exception)"/>
-    public void Error(string formatString, Exception exception)
+    public void Error(string message, Exception exception)
     {
         // Log nothing
     }

diff --git a/src/WireMock.Net/Server/WireMockServer.Admin.cs b/src/WireMock.Net/Server/WireMockServer.Admin.cs
@@ -178,9 +178,9 @@ public void ReadStaticMappings(string? folder = null)
             {
                 ReadStaticMappingAndAddOrUpdate(filename);
             }
-            catch
+            catch (Exception exception)
             {
-                _settings.Logger.Error("Static MappingFile : '{0}' could not be read. This file will be skipped.", filename);
+                _settings.Logger.Error($"Static MappingFile : '{filename}' could not be read. This file will be skipped.", exception);
             }
         }
     }