Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Fix hard coded CSS for User names in main Wishlists page. #160

Closed
wants to merge 4 commits into from

Conversation

Deanosim
Copy link

@Deanosim Deanosim commented Dec 3, 2024

The CSS for the color of Users names in the Wishlist page is hard coded into the a html element, by moving it from https://github.com/Wingysam/Christmas-Community/blob/master/src/views/wishlists.pug to https://github.com/Wingysam/Christmas-Community/blob/master/src/static/css/main.css it allows users to over ride and customize the css for the names.
It also allows users to change the text color to something that is readable when using dark bulma themes.
image
You can see in a dark theme the Names are very hard to read without changing them with custom.css
image
As you can see in the below screenshot the inline css has higher priority than all other css options so it needs to be moved to main.css
image

@Deanosim Deanosim changed the title Fix hard coded CSS for User names in main Wishlist page. Fix hard coded CSS for User names in main Wishlists page. Dec 3, 2024
}
ul li div.box a {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be using a class rather than a selector like this.

@Wingysam Wingysam changed the title Fix hard coded CSS for User names in main Wishlists page. refactor: Fix hard coded CSS for User names in main Wishlists page. Jan 24, 2025
@cj13579
Copy link
Contributor

cj13579 commented Mar 4, 2025

@Deanosim can you resolve the conflicts and update to a class so that we can merge this in?

@Deanosim
Copy link
Author

Deanosim commented Mar 4, 2025

Okay I think I've fixed the conflicts and changed it to a class, hopefully I've done that correctly.

Although now all the wishlist items after the first are broken, so clearly I'm doing something wrong.

@Deanosim Deanosim closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants