Skip to content

Commit

Permalink
Fix Boost's checking for new VS2017 Version 15.5.0
Browse files Browse the repository at this point in the history
* Update 5 (dated Oct 2017) changes _MSC_VER to 1912.  See
https://blogs.msdn.microsoft.com/vcblog/2017/11/15/msvc-conformance-improvements-in-visual-studio-2017-version-15-5/

* This cause lots of compilation messages (neither Errors nor Warnings)
with the text "Unknown compiler version - please run the configure
tests and report the results".  I have *not* reported this new issue to
Boost.org (they will eventually catchup without my help)

* This tiny patch will prevent those compilation messages until a newer
version of Boost becomes available and WinMerge chooses to adopt it.

* Since this has been a hard message to find twice now (previously with
VS2017 15.3.0), I have added a new filter Boost to the Solution
Explorer, containing a very small selection of boost configuration
files.  Boost itself is too large to include either completely, or even
the reasonably small subset of boost files that WinMerge uses.

* Mimic changes also for VS2015 to add the Boost filter to the Solution
Explorer, even though this problem will never occur with VS2015
  • Loading branch information
GreyMerlin committed Dec 7, 2017
1 parent 4935eab commit 5d35a5e
Show file tree
Hide file tree
Showing 5 changed files with 44 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Externals/boost/boost/config/compiler/visualc.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,8 @@

//
// last known (but un-checked by Boost.org) version is 19.11.25506 (VS 2017 Update 3) - BillGord 15 Aug 2017
#if (_MSC_VER > 1911)
// VS2017 Version 15.5.0 (cl compiler version 19.12.25830.2) updated _MSC_VER to 1912 - BillGord 06 Dec 2017
#if (_MSC_VER > 1912)
# if defined(BOOST_ASSERT_CONFIG)
# error "Unknown compiler version - please run the configure tests and report the results"
# else
Expand Down
3 changes: 3 additions & 0 deletions Src/Merge.vs2015.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -910,6 +910,9 @@
</ClCompile>
</ItemGroup>
<ItemGroup>
<ClInclude Include="..\Externals\boost\boost\config.hpp" />
<ClInclude Include="..\Externals\boost\boost\config\compiler\visualc.hpp" />
<ClInclude Include="..\Externals\boost\boost\config\select_compiler_config.hpp" />
<ClInclude Include="..\Externals\crystaledit\editlib\ccrystaleditview.h" />
<ClInclude Include="..\Externals\crystaledit\editlib\ccrystaltextbuffer.h" />
<ClInclude Include="..\Externals\crystaledit\editlib\ccrystaltextmarkers.h" />
Expand Down
18 changes: 18 additions & 0 deletions Src/Merge.vs2015.vcxproj.filters
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,15 @@
<Filter Include="MFCGui\Common">
<UniqueIdentifier>{297182f0-e39d-4ac4-9df3-315882ce9e07}</UniqueIdentifier>
</Filter>
<Filter Include="Boost">
<UniqueIdentifier>{09e2ca67-f223-4fd6-b380-aca4a63886b5}</UniqueIdentifier>
</Filter>
<Filter Include="Boost\config">
<UniqueIdentifier>{6c139b98-08bf-4639-84f9-3848ad990352}</UniqueIdentifier>
</Filter>
<Filter Include="Boost\config\compiler">
<UniqueIdentifier>{48b82f25-08b5-43e5-bc19-abd5bf4f0ea7}</UniqueIdentifier>
</Filter>
</ItemGroup>
<ItemGroup>
<ClCompile Include="charsets.c">
Expand Down Expand Up @@ -1422,6 +1431,15 @@
<ClInclude Include="..\Externals\crystaledit\editlib\ctextmarkerdlg.h">
<Filter>EditLib</Filter>
</ClInclude>
<ClInclude Include="..\Externals\boost\boost\config.hpp">
<Filter>Boost</Filter>
</ClInclude>
<ClInclude Include="..\Externals\boost\boost\config\compiler\visualc.hpp">
<Filter>Boost\config\compiler</Filter>
</ClInclude>
<ClInclude Include="..\Externals\boost\boost\config\select_compiler_config.hpp">
<Filter>Boost\config</Filter>
</ClInclude>
</ItemGroup>
<ItemGroup>
<None Include="res\binarydiff.ico">
Expand Down
3 changes: 3 additions & 0 deletions Src/Merge.vs2017.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -910,6 +910,9 @@
</ClCompile>
</ItemGroup>
<ItemGroup>
<ClInclude Include="..\Externals\boost\boost\config.hpp" />
<ClInclude Include="..\Externals\boost\boost\config\compiler\visualc.hpp" />
<ClInclude Include="..\Externals\boost\boost\config\select_compiler_config.hpp" />
<ClInclude Include="..\Externals\crystaledit\editlib\ccrystaleditview.h" />
<ClInclude Include="..\Externals\crystaledit\editlib\ccrystaltextbuffer.h" />
<ClInclude Include="..\Externals\crystaledit\editlib\ccrystaltextmarkers.h" />
Expand Down
18 changes: 18 additions & 0 deletions Src/Merge.vs2017.vcxproj.filters
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,15 @@
<Filter Include="MFCGui\Common">
<UniqueIdentifier>{297182f0-e39d-4ac4-9df3-315882ce9e07}</UniqueIdentifier>
</Filter>
<Filter Include="Boost">
<UniqueIdentifier>{09e2ca67-f223-4fd6-b380-aca4a63886b5}</UniqueIdentifier>
</Filter>
<Filter Include="Boost\config">
<UniqueIdentifier>{6c139b98-08bf-4639-84f9-3848ad990352}</UniqueIdentifier>
</Filter>
<Filter Include="Boost\config\compiler">
<UniqueIdentifier>{48b82f25-08b5-43e5-bc19-abd5bf4f0ea7}</UniqueIdentifier>
</Filter>
</ItemGroup>
<ItemGroup>
<ClCompile Include="charsets.c">
Expand Down Expand Up @@ -1422,6 +1431,15 @@
<ClInclude Include="..\Externals\crystaledit\editlib\ctextmarkerdlg.h">
<Filter>EditLib</Filter>
</ClInclude>
<ClInclude Include="..\Externals\boost\boost\config.hpp">
<Filter>Boost</Filter>
</ClInclude>
<ClInclude Include="..\Externals\boost\boost\config\compiler\visualc.hpp">
<Filter>Boost\config\compiler</Filter>
</ClInclude>
<ClInclude Include="..\Externals\boost\boost\config\select_compiler_config.hpp">
<Filter>Boost\config</Filter>
</ClInclude>
</ItemGroup>
<ItemGroup>
<None Include="res\binarydiff.ico">
Expand Down

0 comments on commit 5d35a5e

Please sign in to comment.