Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locked sqlalchemy version #2

Merged
merged 1 commit into from
Jan 19, 2024
Merged

locked sqlalchemy version #2

merged 1 commit into from
Jan 19, 2024

Conversation

jlloyd-widen
Copy link
Contributor

Getting an error in the mysql tap that didn't recognize a particular method. Tried locking sqlachemy and using a future/backwards compatible method as a replacement.

SDarmamulia
SDarmamulia previously approved these changes Jan 19, 2024
Copy link

@SDarmamulia SDarmamulia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to test it, but looks ok at a glance.

Note: Are you not joining date_dim for storage count?

@jlloyd-widen
Copy link
Contributor Author

Note: Are you not joining date_dim for storage count?

No, not here. This is just mimicking the snapshot table as it is, not trying to produce the entire history in one go. There is no date_dim in the DAM mysql instances to pull that off with.

@jlloyd-widen jlloyd-widen merged commit 29ac603 into main Jan 19, 2024
1 check passed
@jlloyd-widen jlloyd-widen deleted the row-keys branch January 19, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants