Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom streams based on provided sql query #1

Merged
merged 8 commits into from
Jan 17, 2024

Conversation

jlloyd-widen
Copy link
Contributor

The intent here is to enable the ability take a custom sql query and, if necessary, loop through each schema in a MySQL instance running the same query. This obviously requires a single-tenant data structure (i.e., single tenant per MySQL schema with each schema having the same tables and table schemas).

Of course, this looping functionality can be ignored resulting in a custom stream that is defined by the query itself.

Copy link
Member

@dbeg dbeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the actual code seems legit. Just some questions and nitpicks below.

README.md Show resolved Hide resolved
meltano.yml Outdated Show resolved Hide resolved
tests/test_core.py Outdated Show resolved Hide resolved
tap_mysql/tap.py Show resolved Hide resolved
@jlloyd-widen
Copy link
Contributor Author

@dbeg or @SDarmamulia just looking for the final approval before I can merge. Let me know if there's something else I should address.

@jlloyd-widen jlloyd-widen merged commit d1dee00 into main Jan 17, 2024
1 check passed
@jlloyd-widen jlloyd-widen deleted the custom_query_streams branch January 17, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants