New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PDFMerger.php #55

Open

basantashubhu wants to merge 2 commits into Webklex:master from basantashubhu:master

basantashubhu commented Dec 30, 2024

This pull request includes (TLDR;):

fixed return type in docstring
code simplification using php shorthand

Return type modifications for method chaining:

src/PDFMerger/PDFMerger.php: Changed the return type of the setFileName method from string to self to allow method chaining.
src/PDFMerger/PDFMerger.php: Changed the return type of the addString method from string to self to allow method chaining.

Code simplification using null coalescing operator:

src/PDFMerger/PDFMerger.php: Replaced isset checks with the null coalescing operator (??) in the doMerge method to simplify the code. [1] [2]

basantashubhu added 2 commits

December 30, 2024 14:27


          Update PDFMerger.php

abb7d0f

fixed typos in docstring
used php shorthand for better code


          Update docstring in PDFMerger.php

bc610d6

updated docstring for function addString

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet