Add Functionality to Add PDFs from Amazon S3 #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the only way to add PDFs is through the function
addPDF()
that can only be linked to pdfs that already exist on the local, and integration or inclusion to the plugin to pull pdfs from Amazon S3 buckets before including them would be very useful to users. This addition would provide more flexibility and better user experience, helping users merge from pdfs in the cloud without necessarily downloading them locally.For us to achieve this, we propose to add another function
addPDFFromS3()
to the plugin that will factor the file’s path on S3, and all the other parameters familiar with the existingaddPDF()
function.