Only render things once - fixes #3103 #3107
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3103 by waiting for both the /things and /groups WebSocket connections to open before firing a refresh things event, rather than firing it twice.
I don't love this because it will slightly delay the rendering of Things on the screen until two TCP sockets have opened, but otherwise we're doing all the work twice.
There is still room for improvement because the /things endpoint is still fetched twice (it was fetched three times before), and I think in the thing detail view
refreshThing()
is still called a second time once the sockets have opened.Further refinements could potentially be made by implementing the W3C WoT Discovery Directory Service API (#2857), which provides more information in event payloads so that the whole collection of things doesn't have to be re-rendered for every small change to a Thing.