Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Fixed the directory upload test #477

Open
wants to merge 1 commit into
base: version-8.0
Choose a base branch
from

Conversation

phistuck
Copy link

Included a prefixed version.

I cannot find any specification that defined HTMLInputElement.prototype.directory (perhaps an old version of https://wicg.github.io/directory-upload/proposal.html - no idea) and Chrome does support a prefixed version of that (webkitDirectory) anyway, however, it does not support window.Directory (or any prefixed equivalent), so I think it is fine to use that for now instead of relying on a specification that is changing as we speak.

It makes sense to me to just put it in a bonus points section. Also, a link to the specification is missing.

Included a prefixed version.
@NielsLeenheer
Copy link
Collaborator

The webkitDirectory property is unrelated to this specification. It is a proprietary implementation that is not part of any specification.

And you are right regarding the directory property not existing (anymore). It is renamed to allowdirs, probably to avoid conflicts with webkitDirectory.

So, the test should be fixed, but webkitDirectory should not be part of it. Perhaps that can be a separate test for next update (in 2-3 months).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants